Gsyfuy

I am trying to override "AdminhtmlOrderInvoiceSave" controller, So I made changes in di.xml as below -

<preference for="MagentoSalesControllerAdminhtmlOrderInvoiceSave" type="CustomcodeProductserialnoControllerSalesAdminhtmlOrderInvoiceSave" />

And create as save.php controller at location -
CustomcodeProductserialnoControllerSalesAdminhtmlOrderInvoiceSave.php

and overide its execute function like below -

namespace CustomcodeProductserialnoControllerSalesAdminhtmlOrderInvoice;



    class Save extends MagentoSalesControllerAdminhtmlOrderInvoiceSave

    {



        public function execute()

        {

           /** @var MagentoBackendModelViewResultRedirect $resultRedirect */

            ====

            ....................

            ........................

            default code............

            ......................



            try {

                $invoiceData = $this->getRequest()->getParam('invoice', []);

                $invoiceItems = isset($invoiceData['items']) ? $invoiceData['items'] : [];



                /** @var MagentoSalesModelOrder $order */

                $order = $this->_objectManager->create('MagentoSalesModelOrder')->load($orderId);

                if (!$order->getId()) {

                    throw new MagentoFrameworkExceptionLocalizedException(__('The order no longer exists.'));

                }



                if (!$order->canInvoice()) {

                    throw new MagentoFrameworkExceptionLocalizedException(

                        __('The order does not allow an invoice to be created.')

                    );

                }

                //====on below line its giving error========     

                $invoice = $this->invoiceService->prepareInvoice($order, $invoiceItems);



                if (!$invoice) {

                    throw new LocalizedException(__('We can't save the invoice right now.'));

                }



                if (!$invoice->getTotalQty()) {

                    throw new MagentoFrameworkExceptionLocalizedException(

                        __('You can't create an invoice without products.')

                    );

                }

                $this->registry->register('current_invoice', $invoice);

                if (!empty($data['capture_case'])) {

                    $invoice->setRequestedCaptureCase($data['capture_case']);

                }



                if (!empty($data['comment_text'])) {

                    $invoice->addComment(

                        $data['comment_text'],

                        isset($data['comment_customer_notify']),

                        isset($data['is_visible_on_front'])

                    );



                    $invoice->setCustomerNote($data['comment_text']);

                    $invoice->setCustomerNoteNotify(isset($data['comment_customer_notify']));

                }



                $invoice->register();



                $invoice->getOrder()->setCustomerNoteNotify(!empty($data['send_email']));

                $invoice->getOrder()->setIsInProcess(true);



                $transactionSave = $this->_objectManager->create(

                    'MagentoFrameworkDBTransaction'

                )->addObject(

                    $invoice

                )->addObject(

                    $invoice->getOrder()

                );

                $shipment = false;

                if (!empty($data['do_shipment']) || (int)$invoice->getOrder()->getForcedShipmentWithInvoice()) {

                    $shipment = $this->_prepareShipment($invoice);

                    if ($shipment) {

                        $transactionSave->addObject($shipment);

                    }

                }

                $transactionSave->save();

                //=================

                //===My custom code========

                //=================

                //....................

                ........................

                default code............

                ......................



                return $resultRedirect->setPath('sales/order/view', ['order_id' => $orderId]);

            } catch (LocalizedException $e) {

                $this->messageManager->addError($e->getMessage());

            } catch (Exception $e) {

                echo "<pre>"; 

                print_r($e->getMessage()); die;

                $this->messageManager->addError(__('We can't save the invoice right now.'));

                $this->_objectManager->get('PsrLogLoggerInterface')->critical($e);

            }

            return $resultRedirect->setPath('sales/*/new', ['order_id' => $orderId]);

        }

    }

On this line its giving me error -

$invoice = $this->invoiceService->prepareInvoice($order, $invoiceItems);

Error - : Notice: Undefined property: CustomcodeProductserialnoControllerSalesAdminhtmlOrderInvoiceSaveInterceptor::$invoiceService in /var/www/html/git_projects/testbeat/app/code/Customcode/Productserialno/Controller/Sales/Adminhtml/Order/Invoice/Save.php on line 51

Please let me know what I am doing wrong .

Thanks

The scope of this variable is private. Hence you can't use this in your overriding (inherited) class. please inject MagentoSalesModelServiceInvoiceService class for this variable in your constructor as it is injected into the main class.

Don't forget to run upgrade and di:compile commands after DI.

Edit: try this in your class

<?php



namespace CustomcodeProductserialnoControllerSalesAdminhtmlOrderInvoice;





use MagentoBackendAppAction;

use MagentoFrameworkRegistry;

use MagentoSalesModelOrderEmailSenderInvoiceSender;

use MagentoSalesModelOrderEmailSenderShipmentSender;

use MagentoSalesModelOrderShipmentFactory;

use MagentoSalesModelServiceInvoiceService;



class Save extends MagentoSalesControllerAdminhtmlOrderInvoiceSave

{

    /**

     * @var InvoiceService

     */

    private $invoiceService;



    public function __construct

    (

        ActionContext $context,

        Registry $registry,

        InvoiceSender $invoiceSender,

        ShipmentSender $shipmentSender,

        ShipmentFactory $shipmentFactory,

        InvoiceService $invoiceService

    )

    {

        $this->invoiceService = $invoiceService;

        parent::__construct($context, $registry, $invoiceSender, $shipmentSender, $shipmentFactory, $invoiceService);

    }



    /**

     * Save invoice

     * We can save only new invoice. Existing invoices are not editable

     *

     * @return MagentoFrameworkControllerResultInterface

     *

     * @SuppressWarnings(PHPMD.CyclomaticComplexity)

     * @SuppressWarnings(PHPMD.NPathComplexity)

     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)

     */

    public function execute()

    {

        ..........................

        .......All code with customization------

    }

}

=================My Code is this ===================

namespace CustomcodeProductserialnoControllerSalesAdminhtmlOrderInvoice;



class Save extends MagentoSalesControllerAdminhtmlOrderInvoiceSave

{

    /**

     * @var InvoiceService

     */

    private $invoiceService;



    public function __construct(

        MagentoBackendAppAction $context,

        Registry $registry,

        InvoiceSender $invoiceSender,

        ShipmentSender $shipmentSender,

        ShipmentFactory $shipmentFactory,

        InvoiceService $invoiceService

    ) {

        parent::__construct($context, $registry, $invoiceSender, $shipmentSender, $shipmentFactory, $invoiceService);

    }



  public function execute() { 

..........................

.......All code with customization------

}



}

Plz check because my code still giving same error.
Recoverable Error: Argument 1 passed to CustomcodeProductserialnoControllerSalesAdminhtmlOrderInvoiceSave::__construct() must be an instance of MagentoBackendAppAction,

Plz let me know what I m doing wrong.