How to know if today is second or fourth SaturdayTrying to use global variables for referencing directories...

How to say "Brexit" in Latin?

Positioning node within rectangle Tikz

Does theoretical physics suggest that gravity is the exchange of gravitons or deformation/bending of spacetime?

Can a hotel cancel a confirmed reservation?

Nested word series [humans only]

Is Swahili a Mora-counting language like Japanese?

Removing disk while game is suspended

Is a new Boolean field better than a null reference when a value can be meaningfully absent?

How did Ancient Greek 'πυρ' become English 'fire?'

Why is working on the same position for more than 15 years not a red flag?

Why did the villain in the first Men in Black movie care about Earth's Cockroaches?

Why exactly do action photographers need high fps burst cameras?

Making him into a bully (how to show mild violence)

How to deal with an incendiary email that was recalled

Eww, those bytes are gross

Can a Pact of the Blade warlock use the correct existing pact magic weapon so it functions as a "Returning" weapon?

Do authors have to be politically correct in article-writing?

Is using an 'empty' metaphor considered bad style?

A title for a history book

When can a QA tester start his job?

How can I get my players to come to the game session after agreeing to a date?

What is the purpose of easy combat scenarios that don't need resource expenditure?

Cookies - Should the toggles be on?

What is the wife of a henpecked husband called?



How to know if today is second or fourth Saturday


Trying to use global variables for referencing directories in Python 2.5Finding the date from “2nd Friday of X month”-style inputTDD Hackerrank: Library FinesOrdering an un-ambiguous scrambled dateStart and end times of recurring eventsReading a repetitive file with repetitive codePython library for calculating next and previous time of the cron-like scheduled taskWeb scraping news articles with Beautiful SoupCleaning up date strings in PythonProgram to check if a date is valid or not













2












$begingroup$


This is working. Is it ok?



import calendar
from datetime import datetime


def second_fourth_saturday(year):
holidays = {}
for month in range(1, 13):
holidays[month] = []
cal = calendar.monthcalendar(year, month)
if cal[0][calendar.SATURDAY]:
holidays[month] = (
cal[1][calendar.SATURDAY],
cal[3][calendar.SATURDAY]
)
else:
holidays[month] = (
cal[2][calendar.SATURDAY],
cal[4][calendar.SATURDAY]
)
return holidays


if __name__ == "__main__":
today = datetime.today().day
tomonth = datetime.today().month
if today in second_fourth_saturday(2019)[tomonth]:
print("Enjoy")
else:
print("Start Working")









share|improve this question











$endgroup$












  • $begingroup$
    Do you mean that your program takes the current day and returns whether that current day happens to be the second or fourth Saturday of the current month?
    $endgroup$
    – okcapp
    4 hours ago
















2












$begingroup$


This is working. Is it ok?



import calendar
from datetime import datetime


def second_fourth_saturday(year):
holidays = {}
for month in range(1, 13):
holidays[month] = []
cal = calendar.monthcalendar(year, month)
if cal[0][calendar.SATURDAY]:
holidays[month] = (
cal[1][calendar.SATURDAY],
cal[3][calendar.SATURDAY]
)
else:
holidays[month] = (
cal[2][calendar.SATURDAY],
cal[4][calendar.SATURDAY]
)
return holidays


if __name__ == "__main__":
today = datetime.today().day
tomonth = datetime.today().month
if today in second_fourth_saturday(2019)[tomonth]:
print("Enjoy")
else:
print("Start Working")









share|improve this question











$endgroup$












  • $begingroup$
    Do you mean that your program takes the current day and returns whether that current day happens to be the second or fourth Saturday of the current month?
    $endgroup$
    – okcapp
    4 hours ago














2












2








2





$begingroup$


This is working. Is it ok?



import calendar
from datetime import datetime


def second_fourth_saturday(year):
holidays = {}
for month in range(1, 13):
holidays[month] = []
cal = calendar.monthcalendar(year, month)
if cal[0][calendar.SATURDAY]:
holidays[month] = (
cal[1][calendar.SATURDAY],
cal[3][calendar.SATURDAY]
)
else:
holidays[month] = (
cal[2][calendar.SATURDAY],
cal[4][calendar.SATURDAY]
)
return holidays


if __name__ == "__main__":
today = datetime.today().day
tomonth = datetime.today().month
if today in second_fourth_saturday(2019)[tomonth]:
print("Enjoy")
else:
print("Start Working")









share|improve this question











$endgroup$




This is working. Is it ok?



import calendar
from datetime import datetime


def second_fourth_saturday(year):
holidays = {}
for month in range(1, 13):
holidays[month] = []
cal = calendar.monthcalendar(year, month)
if cal[0][calendar.SATURDAY]:
holidays[month] = (
cal[1][calendar.SATURDAY],
cal[3][calendar.SATURDAY]
)
else:
holidays[month] = (
cal[2][calendar.SATURDAY],
cal[4][calendar.SATURDAY]
)
return holidays


if __name__ == "__main__":
today = datetime.today().day
tomonth = datetime.today().month
if today in second_fourth_saturday(2019)[tomonth]:
print("Enjoy")
else:
print("Start Working")






python python-3.x






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 4 hours ago







Rahul Patel

















asked 4 hours ago









Rahul PatelRahul Patel

232413




232413












  • $begingroup$
    Do you mean that your program takes the current day and returns whether that current day happens to be the second or fourth Saturday of the current month?
    $endgroup$
    – okcapp
    4 hours ago


















  • $begingroup$
    Do you mean that your program takes the current day and returns whether that current day happens to be the second or fourth Saturday of the current month?
    $endgroup$
    – okcapp
    4 hours ago
















$begingroup$
Do you mean that your program takes the current day and returns whether that current day happens to be the second or fourth Saturday of the current month?
$endgroup$
– okcapp
4 hours ago




$begingroup$
Do you mean that your program takes the current day and returns whether that current day happens to be the second or fourth Saturday of the current month?
$endgroup$
– okcapp
4 hours ago










1 Answer
1






active

oldest

votes


















4












$begingroup$

A few suggestions





  • collections.defaultdict




    holidays = {}
    for month in range(1, 13):
    holidays[month] = []
    ...



    There is a module for dictionaries starting with a basic datatype



    from collections import defaultdict
    holidays = defaultdict(tuple)


    Secondly you first init it as a list, and afterwards you make it a tuple this is odd. Pick one and stick with it




  • You don't have to calculate all the months only the specific month



    Since you already know which month it is now, just calculate only the month you are interested in



    To do this you would have to give the month as a second parameter



    def second_fourth_saturday(year, month):
    cal = calendar.monthcalendar(year, month)
    ...



  • Don't Repeat Yourself




    if cal[0][calendar.SATURDAY]:
    holidays[month] = (
    cal[1][calendar.SATURDAY],
    cal[3][calendar.SATURDAY]
    )
    else:
    holidays[month] = (
    cal[2][calendar.SATURDAY],
    cal[4][calendar.SATURDAY]
    )



    If you calculate the weeks beforehand you don't have to repeat yourself



    second_fourth_saturday = (1, 3) if cal[0][calendar.SATURDAY] else (2, 4)



  • Return what is asked



    Instead of return a dict of month with second/fourth saturdays, I think it would be more clear if the function returns a boolean value if the day is a second or fourth saturday




Code



from calendar import monthcalendar, SATURDAY
from datetime import datetime

def second_fourth_saturday(date):
month_calender = monthcalendar(date.year, date.month)
second_fourth_saturday = (1, 3) if month_calender[0][SATURDAY] else (2, 4)
return any(date.day == month_calender[i][SATURDAY] for i in second_fourth_saturday)

if __name__ == "__main__":
is_second_fourth_saturday = second_fourth_saturday(datetime.today())
print("Enjoy" if is_second_fourth_saturday else "Start working")





share|improve this answer









$endgroup$













  • $begingroup$
    Really useful. Thanks.
    $endgroup$
    – Rahul Patel
    1 hour ago











Your Answer





StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214443%2fhow-to-know-if-today-is-second-or-fourth-saturday%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









4












$begingroup$

A few suggestions





  • collections.defaultdict




    holidays = {}
    for month in range(1, 13):
    holidays[month] = []
    ...



    There is a module for dictionaries starting with a basic datatype



    from collections import defaultdict
    holidays = defaultdict(tuple)


    Secondly you first init it as a list, and afterwards you make it a tuple this is odd. Pick one and stick with it




  • You don't have to calculate all the months only the specific month



    Since you already know which month it is now, just calculate only the month you are interested in



    To do this you would have to give the month as a second parameter



    def second_fourth_saturday(year, month):
    cal = calendar.monthcalendar(year, month)
    ...



  • Don't Repeat Yourself




    if cal[0][calendar.SATURDAY]:
    holidays[month] = (
    cal[1][calendar.SATURDAY],
    cal[3][calendar.SATURDAY]
    )
    else:
    holidays[month] = (
    cal[2][calendar.SATURDAY],
    cal[4][calendar.SATURDAY]
    )



    If you calculate the weeks beforehand you don't have to repeat yourself



    second_fourth_saturday = (1, 3) if cal[0][calendar.SATURDAY] else (2, 4)



  • Return what is asked



    Instead of return a dict of month with second/fourth saturdays, I think it would be more clear if the function returns a boolean value if the day is a second or fourth saturday




Code



from calendar import monthcalendar, SATURDAY
from datetime import datetime

def second_fourth_saturday(date):
month_calender = monthcalendar(date.year, date.month)
second_fourth_saturday = (1, 3) if month_calender[0][SATURDAY] else (2, 4)
return any(date.day == month_calender[i][SATURDAY] for i in second_fourth_saturday)

if __name__ == "__main__":
is_second_fourth_saturday = second_fourth_saturday(datetime.today())
print("Enjoy" if is_second_fourth_saturday else "Start working")





share|improve this answer









$endgroup$













  • $begingroup$
    Really useful. Thanks.
    $endgroup$
    – Rahul Patel
    1 hour ago
















4












$begingroup$

A few suggestions





  • collections.defaultdict




    holidays = {}
    for month in range(1, 13):
    holidays[month] = []
    ...



    There is a module for dictionaries starting with a basic datatype



    from collections import defaultdict
    holidays = defaultdict(tuple)


    Secondly you first init it as a list, and afterwards you make it a tuple this is odd. Pick one and stick with it




  • You don't have to calculate all the months only the specific month



    Since you already know which month it is now, just calculate only the month you are interested in



    To do this you would have to give the month as a second parameter



    def second_fourth_saturday(year, month):
    cal = calendar.monthcalendar(year, month)
    ...



  • Don't Repeat Yourself




    if cal[0][calendar.SATURDAY]:
    holidays[month] = (
    cal[1][calendar.SATURDAY],
    cal[3][calendar.SATURDAY]
    )
    else:
    holidays[month] = (
    cal[2][calendar.SATURDAY],
    cal[4][calendar.SATURDAY]
    )



    If you calculate the weeks beforehand you don't have to repeat yourself



    second_fourth_saturday = (1, 3) if cal[0][calendar.SATURDAY] else (2, 4)



  • Return what is asked



    Instead of return a dict of month with second/fourth saturdays, I think it would be more clear if the function returns a boolean value if the day is a second or fourth saturday




Code



from calendar import monthcalendar, SATURDAY
from datetime import datetime

def second_fourth_saturday(date):
month_calender = monthcalendar(date.year, date.month)
second_fourth_saturday = (1, 3) if month_calender[0][SATURDAY] else (2, 4)
return any(date.day == month_calender[i][SATURDAY] for i in second_fourth_saturday)

if __name__ == "__main__":
is_second_fourth_saturday = second_fourth_saturday(datetime.today())
print("Enjoy" if is_second_fourth_saturday else "Start working")





share|improve this answer









$endgroup$













  • $begingroup$
    Really useful. Thanks.
    $endgroup$
    – Rahul Patel
    1 hour ago














4












4








4





$begingroup$

A few suggestions





  • collections.defaultdict




    holidays = {}
    for month in range(1, 13):
    holidays[month] = []
    ...



    There is a module for dictionaries starting with a basic datatype



    from collections import defaultdict
    holidays = defaultdict(tuple)


    Secondly you first init it as a list, and afterwards you make it a tuple this is odd. Pick one and stick with it




  • You don't have to calculate all the months only the specific month



    Since you already know which month it is now, just calculate only the month you are interested in



    To do this you would have to give the month as a second parameter



    def second_fourth_saturday(year, month):
    cal = calendar.monthcalendar(year, month)
    ...



  • Don't Repeat Yourself




    if cal[0][calendar.SATURDAY]:
    holidays[month] = (
    cal[1][calendar.SATURDAY],
    cal[3][calendar.SATURDAY]
    )
    else:
    holidays[month] = (
    cal[2][calendar.SATURDAY],
    cal[4][calendar.SATURDAY]
    )



    If you calculate the weeks beforehand you don't have to repeat yourself



    second_fourth_saturday = (1, 3) if cal[0][calendar.SATURDAY] else (2, 4)



  • Return what is asked



    Instead of return a dict of month with second/fourth saturdays, I think it would be more clear if the function returns a boolean value if the day is a second or fourth saturday




Code



from calendar import monthcalendar, SATURDAY
from datetime import datetime

def second_fourth_saturday(date):
month_calender = monthcalendar(date.year, date.month)
second_fourth_saturday = (1, 3) if month_calender[0][SATURDAY] else (2, 4)
return any(date.day == month_calender[i][SATURDAY] for i in second_fourth_saturday)

if __name__ == "__main__":
is_second_fourth_saturday = second_fourth_saturday(datetime.today())
print("Enjoy" if is_second_fourth_saturday else "Start working")





share|improve this answer









$endgroup$



A few suggestions





  • collections.defaultdict




    holidays = {}
    for month in range(1, 13):
    holidays[month] = []
    ...



    There is a module for dictionaries starting with a basic datatype



    from collections import defaultdict
    holidays = defaultdict(tuple)


    Secondly you first init it as a list, and afterwards you make it a tuple this is odd. Pick one and stick with it




  • You don't have to calculate all the months only the specific month



    Since you already know which month it is now, just calculate only the month you are interested in



    To do this you would have to give the month as a second parameter



    def second_fourth_saturday(year, month):
    cal = calendar.monthcalendar(year, month)
    ...



  • Don't Repeat Yourself




    if cal[0][calendar.SATURDAY]:
    holidays[month] = (
    cal[1][calendar.SATURDAY],
    cal[3][calendar.SATURDAY]
    )
    else:
    holidays[month] = (
    cal[2][calendar.SATURDAY],
    cal[4][calendar.SATURDAY]
    )



    If you calculate the weeks beforehand you don't have to repeat yourself



    second_fourth_saturday = (1, 3) if cal[0][calendar.SATURDAY] else (2, 4)



  • Return what is asked



    Instead of return a dict of month with second/fourth saturdays, I think it would be more clear if the function returns a boolean value if the day is a second or fourth saturday




Code



from calendar import monthcalendar, SATURDAY
from datetime import datetime

def second_fourth_saturday(date):
month_calender = monthcalendar(date.year, date.month)
second_fourth_saturday = (1, 3) if month_calender[0][SATURDAY] else (2, 4)
return any(date.day == month_calender[i][SATURDAY] for i in second_fourth_saturday)

if __name__ == "__main__":
is_second_fourth_saturday = second_fourth_saturday(datetime.today())
print("Enjoy" if is_second_fourth_saturday else "Start working")






share|improve this answer












share|improve this answer



share|improve this answer










answered 2 hours ago









LudisposedLudisposed

8,19222161




8,19222161












  • $begingroup$
    Really useful. Thanks.
    $endgroup$
    – Rahul Patel
    1 hour ago


















  • $begingroup$
    Really useful. Thanks.
    $endgroup$
    – Rahul Patel
    1 hour ago
















$begingroup$
Really useful. Thanks.
$endgroup$
– Rahul Patel
1 hour ago




$begingroup$
Really useful. Thanks.
$endgroup$
– Rahul Patel
1 hour ago


















draft saved

draft discarded




















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214443%2fhow-to-know-if-today-is-second-or-fourth-saturday%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

“%fieldName is a required field.”, in Magento2 REST API Call for GET Method Type The Next...

How to change City field to a dropdown in Checkout step Magento 2Magento 2 : How to change UI field(s)...

變成蝙蝠會怎樣? 參考資料 外部連結 导航菜单Thomas Nagel, "What is it like to be a...