Gsyfuy

Shortening a title without changing its meaning

Another proof that dividing by 0 does not exist -- is it right?

Are British MPs missing the point, with these 'Indicative Votes'?

Upgrading From a 9 Speed Sora Derailleur?

Small nick on power cord from an electric alarm clock, and copper wiring exposed but intact

Do I need to write [sic] when including a quotation with a number less than 10 that isn't written out?

Horror film about a man brought out of cryogenic suspension without a soul, around 1990

Is there a rule of thumb for determining the amount one should accept for a settlement offer?

Which acid/base does a strong base/acid react when added to a buffer solution?

Man transported from Alternate World into ours by a Neutrino Detector

Planeswalker Ability and Death Timing

Why did the Drakh emissary look so blurred in S04:E11 "Lines of Communication"?

Car headlights in a world without electricity

How should I connect my cat5 cable to connectors having an orange-green line?

Is a distribution that is normal, but highly skewed, considered Gaussian?

Is it okay to majorly distort historical facts while writing a fiction story?

Is it a bad idea to plug the other end of ESD strap to wall ground?

How to pronounce fünf in 45

Is it correct to say moon starry nights?

Simplify trigonometric expression using trigonometric identities

Raspberry pi 3 B with Ubuntu 18.04 server arm64: what pi version

Is it reasonable to ask other researchers to send me their previous grant applications?

Could you use a laser beam as a modulated carrier wave for radio signal?

Salesforce opportunity stages

How should I verify that an integer value passed in from argv won't overflow?

6

0

I have a program that requires the user to enter an integer as a command line argument, in the form of ./program 100.

Obviously this will read the value in as a string, so I need to parse it to an integer. I have to ensure that the input value won't overflow an integer variable. I have read about strtol(), but it works with long variables and I have to stick with a regular int.

Is there anything similar that can be used for an int?

c

share|improve this question

asked 5 hours ago

JakeJake

109212

• 
  
  
  

  
  7
  

  
  
  
  
  
  

  
  
  Use strtol and compare to INT_MAX/MIN.
  
  – Eugene Sh.
  5 hours ago
  

  
  
  
  


• 
  
  
  

  
  2
  

  
  
  
  
  
  

  
  
  if (longvalue > INT_MAX) /* overflow */; don't forget to #include <limits.h>
  
  – pmg
  5 hours ago
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @pmg check would fail for platforms when sizeof(int) == sizeof(long) = true.
  
  – SergeyA
  4 hours ago
  
  
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @pmg, you can do it in a single check by just comparing for >= INT_MAX. This will always work.
  
  – SergeyA
  4 hours ago
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @SergeyA Yeah, apparently one should handle strtol errors too. I assumed OP is already aware of that when mentioned using strtol.
  
  – Eugene Sh.
  4 hours ago
  

  
  
  
  

 | 
show 10 more comments

6

0

I have a program that requires the user to enter an integer as a command line argument, in the form of ./program 100.

Obviously this will read the value in as a string, so I need to parse it to an integer. I have to ensure that the input value won't overflow an integer variable. I have read about strtol(), but it works with long variables and I have to stick with a regular int.

Is there anything similar that can be used for an int?

c

share|improve this question

asked 5 hours ago

JakeJake

109212

• 
  
  
  

  
  7
  

  
  
  
  
  
  

  
  
  Use strtol and compare to INT_MAX/MIN.
  
  – Eugene Sh.
  5 hours ago
  

  
  
  
  


• 
  
  
  

  
  2
  

  
  
  
  
  
  

  
  
  if (longvalue > INT_MAX) /* overflow */; don't forget to #include <limits.h>
  
  – pmg
  5 hours ago
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @pmg check would fail for platforms when sizeof(int) == sizeof(long) = true.
  
  – SergeyA
  4 hours ago
  
  
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @pmg, you can do it in a single check by just comparing for >= INT_MAX. This will always work.
  
  – SergeyA
  4 hours ago
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @SergeyA Yeah, apparently one should handle strtol errors too. I assumed OP is already aware of that when mentioned using strtol.
  
  – Eugene Sh.
  4 hours ago
  

  
  
  
  

 | 
show 10 more comments

I have a program that requires the user to enter an integer as a command line argument, in the form of ./program 100.

Obviously this will read the value in as a string, so I need to parse it to an integer. I have to ensure that the input value won't overflow an integer variable. I have read about strtol(), but it works with long variables and I have to stick with a regular int.

Is there anything similar that can be used for an int?

c

share|improve this question

asked 5 hours ago

JakeJake

109212

share|improve this question

asked 5 hours ago

JakeJake

109212

share|improve this question

asked 5 hours ago

JakeJake

109212

asked 5 hours ago

JakeJake

109212

asked 5 hours ago

JakeJake

109212

2 Answers
2

active

oldest

votes

5

You can use strtol for this. You'll first need to check if this function fails to convert the value. If it convert successfully, then check if the value is in the range of INT_MIN to INT_MAX:

errno = 0;

long x = strtol(argv[1], NULL, 10);

if (errno) {

    perror("conversion failed");

} else if (x < INT_MIN) {

    printf("value too smalln");

} else if (x > INT_MAX) {

    printf("value too bign");

} else {

    printf("value = %ldn", x);

}

Note that this will work whether long is the same size as int or larger.

If sizeof(long) > sizeof(int), the INT_MIN and INT_MAX checks will catch the cases where the value fits in a long but not an int. If sizeof(long) == sizeof(int), an out of range value will result in errno being set to non-zero to catch the error, and the INT_MIN and INT_MAX cases will never be true.

share|improve this answer

edited 4 hours ago

Keith Thompson

194k26290484

answered 4 hours ago

dbushdbush

103k13108145

• 
  
  
  

  
  2
  

  
  
  
  
  
  

  
  
  Strictly speaking, it's the ranges of int and long that are relevant here, not their sizes. In the presence of padding bits, it's possible for int and long to have the same size, but for long to have a wider range. (Few if any implementations actually use padding bits, though.)
  
  – Keith Thompson
  4 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  if (errno) { is not a sufficient test to detect "conversion failed" as errno can still be 0.
  
  – chux
  1 hour ago
  

  
  
  
  

add a comment | 

1

How should I verify that an integer value passed in from argv won't overflow?

Use strtol() and check the end pointer. Then check errno and maybe a range test

if (argc > 1) {

  char *endptr;

  errno = 0;

  long num = strtol(argv[1], &endptr, 10);



  if (argv[1] == endptr) {

    puts("No conversion");

  } else if (errno == ERANGE) {

    puts("Value outside long range");

  #if LONG_MIN < INT_MIN || LONG_MAX > INT_MAX

  } else if (num < INT_MAX || num > INT_MAX) {

    errno = ERANGE;

    puts("Value outside int range");

  #endif

  } else {

    // If code wants to look for trailing junk

    if (*endptr) {

      puts("Non-numeric text");

    } else {

      printf("Success %dn", (int) num);

    } 

  } 

Based on Why is there no strtoi in stdlib.h?

share|improve this answer

edited 1 hour ago

answered 2 hours ago

chuxchux

84.8k874157

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  #else should be #endif
  
  – chqrlie
  2 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  @chqrlie Yes, code amended.
  
  – chux
  1 hour ago
  

  
  
  
  

add a comment | 

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name

Email

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55462918%2fhow-should-i-verify-that-an-integer-value-passed-in-from-argv-wont-overflow%23new-answer', 'question_page');
}
);

Post as a guest

Name

Email

Required, but never shown

5

You can use strtol for this. You'll first need to check if this function fails to convert the value. If it convert successfully, then check if the value is in the range of INT_MIN to INT_MAX:

errno = 0;

long x = strtol(argv[1], NULL, 10);

if (errno) {

    perror("conversion failed");

} else if (x < INT_MIN) {

    printf("value too smalln");

} else if (x > INT_MAX) {

    printf("value too bign");

} else {

    printf("value = %ldn", x);

}

Note that this will work whether long is the same size as int or larger.

If sizeof(long) > sizeof(int), the INT_MIN and INT_MAX checks will catch the cases where the value fits in a long but not an int. If sizeof(long) == sizeof(int), an out of range value will result in errno being set to non-zero to catch the error, and the INT_MIN and INT_MAX cases will never be true.

share|improve this answer

edited 4 hours ago

Keith Thompson

194k26290484

answered 4 hours ago

dbushdbush

103k13108145

• 
  
  
  

  
  2
  

  
  
  
  
  
  

  
  
  Strictly speaking, it's the ranges of int and long that are relevant here, not their sizes. In the presence of padding bits, it's possible for int and long to have the same size, but for long to have a wider range. (Few if any implementations actually use padding bits, though.)
  
  – Keith Thompson
  4 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  if (errno) { is not a sufficient test to detect "conversion failed" as errno can still be 0.
  
  – chux
  1 hour ago
  

  
  
  
  

add a comment | 

5

You can use strtol for this. You'll first need to check if this function fails to convert the value. If it convert successfully, then check if the value is in the range of INT_MIN to INT_MAX:

errno = 0;

long x = strtol(argv[1], NULL, 10);

if (errno) {

    perror("conversion failed");

} else if (x < INT_MIN) {

    printf("value too smalln");

} else if (x > INT_MAX) {

    printf("value too bign");

} else {

    printf("value = %ldn", x);

}

Note that this will work whether long is the same size as int or larger.

If sizeof(long) > sizeof(int), the INT_MIN and INT_MAX checks will catch the cases where the value fits in a long but not an int. If sizeof(long) == sizeof(int), an out of range value will result in errno being set to non-zero to catch the error, and the INT_MIN and INT_MAX cases will never be true.

share|improve this answer

edited 4 hours ago

Keith Thompson

194k26290484

answered 4 hours ago

dbushdbush

103k13108145

• 
  
  
  

  
  2
  

  
  
  
  
  
  

  
  
  Strictly speaking, it's the ranges of int and long that are relevant here, not their sizes. In the presence of padding bits, it's possible for int and long to have the same size, but for long to have a wider range. (Few if any implementations actually use padding bits, though.)
  
  – Keith Thompson
  4 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  if (errno) { is not a sufficient test to detect "conversion failed" as errno can still be 0.
  
  – chux
  1 hour ago
  

  
  
  
  

add a comment | 

You can use strtol for this. You'll first need to check if this function fails to convert the value. If it convert successfully, then check if the value is in the range of INT_MIN to INT_MAX:

errno = 0;

long x = strtol(argv[1], NULL, 10);

if (errno) {

    perror("conversion failed");

} else if (x < INT_MIN) {

    printf("value too smalln");

} else if (x > INT_MAX) {

    printf("value too bign");

} else {

    printf("value = %ldn", x);

}

Note that this will work whether long is the same size as int or larger.

If sizeof(long) > sizeof(int), the INT_MIN and INT_MAX checks will catch the cases where the value fits in a long but not an int. If sizeof(long) == sizeof(int), an out of range value will result in errno being set to non-zero to catch the error, and the INT_MIN and INT_MAX cases will never be true.

share|improve this answer

edited 4 hours ago

Keith Thompson

194k26290484

answered 4 hours ago

dbushdbush

103k13108145

errno = 0;

long x = strtol(argv[1], NULL, 10);

if (errno) {

    perror("conversion failed");

} else if (x < INT_MIN) {

    printf("value too smalln");

} else if (x > INT_MAX) {

    printf("value too bign");

} else {

    printf("value = %ldn", x);

}

share|improve this answer

edited 4 hours ago

Keith Thompson

194k26290484

answered 4 hours ago

dbushdbush

103k13108145

edited 4 hours ago

Keith Thompson

194k26290484

edited 4 hours ago

Keith Thompson

194k26290484

answered 4 hours ago

dbushdbush

103k13108145

answered 4 hours ago

dbushdbush

103k13108145

1

How should I verify that an integer value passed in from argv won't overflow?

Use strtol() and check the end pointer. Then check errno and maybe a range test

if (argc > 1) {

  char *endptr;

  errno = 0;

  long num = strtol(argv[1], &endptr, 10);



  if (argv[1] == endptr) {

    puts("No conversion");

  } else if (errno == ERANGE) {

    puts("Value outside long range");

  #if LONG_MIN < INT_MIN || LONG_MAX > INT_MAX

  } else if (num < INT_MAX || num > INT_MAX) {

    errno = ERANGE;

    puts("Value outside int range");

  #endif

  } else {

    // If code wants to look for trailing junk

    if (*endptr) {

      puts("Non-numeric text");

    } else {

      printf("Success %dn", (int) num);

    } 

  } 

Based on Why is there no strtoi in stdlib.h?

share|improve this answer

edited 1 hour ago

answered 2 hours ago

chuxchux

84.8k874157

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  #else should be #endif
  
  – chqrlie
  2 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  @chqrlie Yes, code amended.
  
  – chux
  1 hour ago
  

  
  
  
  

add a comment | 

1

How should I verify that an integer value passed in from argv won't overflow?

Use strtol() and check the end pointer. Then check errno and maybe a range test

if (argc > 1) {

  char *endptr;

  errno = 0;

  long num = strtol(argv[1], &endptr, 10);



  if (argv[1] == endptr) {

    puts("No conversion");

  } else if (errno == ERANGE) {

    puts("Value outside long range");

  #if LONG_MIN < INT_MIN || LONG_MAX > INT_MAX

  } else if (num < INT_MAX || num > INT_MAX) {

    errno = ERANGE;

    puts("Value outside int range");

  #endif

  } else {

    // If code wants to look for trailing junk

    if (*endptr) {

      puts("Non-numeric text");

    } else {

      printf("Success %dn", (int) num);

    } 

  } 

Based on Why is there no strtoi in stdlib.h?

share|improve this answer

edited 1 hour ago

answered 2 hours ago

chuxchux

84.8k874157

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  #else should be #endif
  
  – chqrlie
  2 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  @chqrlie Yes, code amended.
  
  – chux
  1 hour ago
  

  
  
  
  

add a comment | 

How should I verify that an integer value passed in from argv won't overflow?

Use strtol() and check the end pointer. Then check errno and maybe a range test

if (argc > 1) {

  char *endptr;

  errno = 0;

  long num = strtol(argv[1], &endptr, 10);



  if (argv[1] == endptr) {

    puts("No conversion");

  } else if (errno == ERANGE) {

    puts("Value outside long range");

  #if LONG_MIN < INT_MIN || LONG_MAX > INT_MAX

  } else if (num < INT_MAX || num > INT_MAX) {

    errno = ERANGE;

    puts("Value outside int range");

  #endif

  } else {

    // If code wants to look for trailing junk

    if (*endptr) {

      puts("Non-numeric text");

    } else {

      printf("Success %dn", (int) num);

    } 

  } 

Based on Why is there no strtoi in stdlib.h?

share|improve this answer

edited 1 hour ago

answered 2 hours ago

chuxchux

84.8k874157

if (argc > 1) {

  char *endptr;

  errno = 0;

  long num = strtol(argv[1], &endptr, 10);



  if (argv[1] == endptr) {

    puts("No conversion");

  } else if (errno == ERANGE) {

    puts("Value outside long range");

  #if LONG_MIN < INT_MIN || LONG_MAX > INT_MAX

  } else if (num < INT_MAX || num > INT_MAX) {

    errno = ERANGE;

    puts("Value outside int range");

  #endif

  } else {

    // If code wants to look for trailing junk

    if (*endptr) {

      puts("Non-numeric text");

    } else {

      printf("Success %dn", (int) num);

    } 

  } 

share|improve this answer

edited 1 hour ago

answered 2 hours ago

chuxchux

84.8k874157

answered 2 hours ago

chuxchux

84.8k874157

answered 2 hours ago

chuxchux

84.8k874157