Gsyfuy

Can the Reverse Gravity spell affect the Meteor Swarm spell?

How can I quit an app using Terminal?

If I blow insulation everywhere in my attic except the door trap, will heat escape through it?

Why does C# sound extremely flat when saxophone is tuned to G?

Inappropriate reference requests from Journal reviewers

Too much space between section and text in a twocolumn document

Are there languages with no euphemisms?

How to Reset Passwords on Multiple Websites Easily?

Grabbing quick drinks

What's the point of interval inversion?

India just shot down a satellite from the ground. At what altitude range is the resulting debris field?

What is the point of a new vote on May's deal when the indicative votes suggest she will not win?

Term for the "extreme-extension" version of a straw man fallacy?

Is it okay to store user locations?

Why here is plural "We went to the movies last night."

How can I open an app using Terminal?

Need some help with wall behind rangetop

How did people program for Consoles with multiple CPUs?

When Does an Atlas Uniquely Define a Manifold?

How can I get through very long and very dry, but also very useful technical documents when learning a new tool?

How to be diplomatic in refusing to write code that breaches the privacy of our users

Why did we only see the N-1 starfighters in one film?

How do we know the LHC results are robust?

What happens if you roll doubles 3 times then land on "Go to jail?"

Magento 2 , How to avaid load() in loop?

2

1

I have created the custom module with an inline edit in the grid, all working fine. once I have running phpsniffer with the EcgM2 standard, I get this warning:

Model LSD method load() detected in loop

magento2 controllers optimization

share|improve this question

edited 22 mins ago

Teja Bhagavan Kollepara

3,01241949

asked Feb 19 '18 at 13:10

user53836

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  refer this link github.com/magento/magento2/issues/10380
  
  – ABHISHEK TRIPATHI
  Feb 19 '18 at 13:13
  

  
  
  
  

add a comment | 

2

1

I have created the custom module with an inline edit in the grid, all working fine. once I have running phpsniffer with the EcgM2 standard, I get this warning:

Model LSD method load() detected in loop

magento2 controllers optimization

share|improve this question

edited 22 mins ago

Teja Bhagavan Kollepara

3,01241949

asked Feb 19 '18 at 13:10

user53836

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  refer this link github.com/magento/magento2/issues/10380
  
  – ABHISHEK TRIPATHI
  Feb 19 '18 at 13:13
  

  
  
  
  

add a comment | 

I have created the custom module with an inline edit in the grid, all working fine. once I have running phpsniffer with the EcgM2 standard, I get this warning:

Model LSD method load() detected in loop

magento2 controllers optimization

share|improve this question

edited 22 mins ago

Teja Bhagavan Kollepara

3,01241949

asked Feb 19 '18 at 13:10

user53836

Model LSD method load() detected in loop

share|improve this question

edited 22 mins ago

Teja Bhagavan Kollepara

3,01241949

asked Feb 19 '18 at 13:10

user53836

share|improve this question

edited 22 mins ago

Teja Bhagavan Kollepara

3,01241949

asked Feb 19 '18 at 13:10

user53836

edited 22 mins ago

Teja Bhagavan Kollepara

3,01241949

edited 22 mins ago

Teja Bhagavan Kollepara

3,01241949

1 Answer
1

active

oldest

votes

1

Use collection and filters to get list of models u need.

Sample below:

/** @var MagentoCatalogModelResourceModelProductCollectionFactory */

protected $collectionFactory;



public function __construct(

    MagentoCatalogModelResourceModelProductCollectionFactory $collectionFactory

) {

    $this->collectionFactory = $collectionFactory;

}



public function yourMethod()

{

    // Use factory to create a new product collection

    $productCollection = $this->collectionFactory->create();

    /** Apply filters here */

    $productCollection->addAttributeToSelect('*');

    // Don't have to do this

    // $productCollection->load();



    foreach ($productCollection as $product){

         echo 'Name  =  '.$product->getName().'<br>';

    }  

}

share|improve this answer

edited Oct 25 '18 at 11:49

answered Oct 25 '18 at 10:27

Wojciech KaWojciech Ka

14514

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  This does not provide an answer to the question. To critique or request clarification from an author, leave a comment below their post. - From Review
  
  – Rama Chandran M
  Oct 25 '18 at 10:56
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  @RamaChandranM its short, but still an answer ...
  
  – sv3n
  Oct 25 '18 at 11:07
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @RamaChandranM I corrected my answer a little bit
  
  – Wojciech Ka
  Oct 25 '18 at 11:50
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Thanks @sv3n, Thanks for updated ans Wqojciech. Some detail explain will help other.
  
  – Rama Chandran M
  Oct 25 '18 at 18:20
  

  
  
  
  

add a comment | 

Your Answer

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "479"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name

Email

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f214086%2fmagento-2-how-to-avaid-load-in-loop%23new-answer', 'question_page');
}
);

Post as a guest

Name

Email

Required, but never shown

1

Use collection and filters to get list of models u need.

Sample below:

/** @var MagentoCatalogModelResourceModelProductCollectionFactory */

protected $collectionFactory;



public function __construct(

    MagentoCatalogModelResourceModelProductCollectionFactory $collectionFactory

) {

    $this->collectionFactory = $collectionFactory;

}



public function yourMethod()

{

    // Use factory to create a new product collection

    $productCollection = $this->collectionFactory->create();

    /** Apply filters here */

    $productCollection->addAttributeToSelect('*');

    // Don't have to do this

    // $productCollection->load();



    foreach ($productCollection as $product){

         echo 'Name  =  '.$product->getName().'<br>';

    }  

}

share|improve this answer

edited Oct 25 '18 at 11:49

answered Oct 25 '18 at 10:27

Wojciech KaWojciech Ka

14514

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  This does not provide an answer to the question. To critique or request clarification from an author, leave a comment below their post. - From Review
  
  – Rama Chandran M
  Oct 25 '18 at 10:56
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  @RamaChandranM its short, but still an answer ...
  
  – sv3n
  Oct 25 '18 at 11:07
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @RamaChandranM I corrected my answer a little bit
  
  – Wojciech Ka
  Oct 25 '18 at 11:50
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Thanks @sv3n, Thanks for updated ans Wqojciech. Some detail explain will help other.
  
  – Rama Chandran M
  Oct 25 '18 at 18:20
  

  
  
  
  

add a comment | 

1

Use collection and filters to get list of models u need.

Sample below:

/** @var MagentoCatalogModelResourceModelProductCollectionFactory */

protected $collectionFactory;



public function __construct(

    MagentoCatalogModelResourceModelProductCollectionFactory $collectionFactory

) {

    $this->collectionFactory = $collectionFactory;

}



public function yourMethod()

{

    // Use factory to create a new product collection

    $productCollection = $this->collectionFactory->create();

    /** Apply filters here */

    $productCollection->addAttributeToSelect('*');

    // Don't have to do this

    // $productCollection->load();



    foreach ($productCollection as $product){

         echo 'Name  =  '.$product->getName().'<br>';

    }  

}

share|improve this answer

edited Oct 25 '18 at 11:49

answered Oct 25 '18 at 10:27

Wojciech KaWojciech Ka

14514

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  This does not provide an answer to the question. To critique or request clarification from an author, leave a comment below their post. - From Review
  
  – Rama Chandran M
  Oct 25 '18 at 10:56
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  @RamaChandranM its short, but still an answer ...
  
  – sv3n
  Oct 25 '18 at 11:07
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  @RamaChandranM I corrected my answer a little bit
  
  – Wojciech Ka
  Oct 25 '18 at 11:50
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Thanks @sv3n, Thanks for updated ans Wqojciech. Some detail explain will help other.
  
  – Rama Chandran M
  Oct 25 '18 at 18:20
  

  
  
  
  

add a comment | 

Use collection and filters to get list of models u need.

Sample below:

/** @var MagentoCatalogModelResourceModelProductCollectionFactory */

protected $collectionFactory;



public function __construct(

    MagentoCatalogModelResourceModelProductCollectionFactory $collectionFactory

) {

    $this->collectionFactory = $collectionFactory;

}



public function yourMethod()

{

    // Use factory to create a new product collection

    $productCollection = $this->collectionFactory->create();

    /** Apply filters here */

    $productCollection->addAttributeToSelect('*');

    // Don't have to do this

    // $productCollection->load();



    foreach ($productCollection as $product){

         echo 'Name  =  '.$product->getName().'<br>';

    }  

}

share|improve this answer

edited Oct 25 '18 at 11:49

answered Oct 25 '18 at 10:27

Wojciech KaWojciech Ka

14514

/** @var MagentoCatalogModelResourceModelProductCollectionFactory */

protected $collectionFactory;



public function __construct(

    MagentoCatalogModelResourceModelProductCollectionFactory $collectionFactory

) {

    $this->collectionFactory = $collectionFactory;

}



public function yourMethod()

{

    // Use factory to create a new product collection

    $productCollection = $this->collectionFactory->create();

    /** Apply filters here */

    $productCollection->addAttributeToSelect('*');

    // Don't have to do this

    // $productCollection->load();



    foreach ($productCollection as $product){

         echo 'Name  =  '.$product->getName().'<br>';

    }  

}

share|improve this answer

edited Oct 25 '18 at 11:49

answered Oct 25 '18 at 10:27

Wojciech KaWojciech Ka

14514

answered Oct 25 '18 at 10:27

Wojciech KaWojciech Ka

14514

answered Oct 25 '18 at 10:27

Wojciech KaWojciech Ka

14514